Index testing improvements #124

honno · 2022-05-23T14:42:12Z

Improves test_getitem and test_setitem:

Test 0-sided shapes.
Factors out key normalisation.
Factors out axes_indices and out_shape inference.

Also

Tests all possible dtypes for test_asarray_arrays.
ph.assert_array() -> ph.assert_array_elements(), not caring about dtypes
Generally introduces more docs/comments, typing fixes, better error messages, and logic simplification.

> Return True for float dtypes that aren't part of the spec e.g. np.float16 Such utility hasn't ended up being desired anywhere

Also `ph.assert_array()` -> `ph.assert_array_elements()`

* Test all possible dtype kwargs * Fix erroneous nan equals * Clean up copy testing

honno · 2022-05-23T19:14:46Z

~~The failing test_linspace on CI looks like a flaky error on our end, will try and fix tomorrow.~~ I'll get back to this later, see #125.

honno added 10 commits May 18, 2022 16:20

Remove dh.is_float_dtype() TODO

5cd2e72

> Return True for float dtypes that aren't part of the spec e.g. np.float16 Such utility hasn't ended up being desired anywhere

Test 0-sided array in test_getitem

34fda92

Test non-0d-resulting keys in test_setitem

ff3fed4

Also `ph.assert_array()` -> `ph.assert_array_elements()`

Test different dtypes in test_setitem

7feaa28

Test unaffected indices more wholly in test_setitem

b1dcf77

Fix scalar_objects() typing

a4dd075

normalise_key() util for indexing tests

131037d

get_indexed_axes_and_out_shape() util for indexing tests

373dd48

Support None in sh.fmt_i()

52e835e

test_asarray_arrays improvements

8a5103b

* Test all possible dtype kwargs * Fix erroneous nan equals * Clean up copy testing

honno merged commit 87834dd into data-apis:master May 24, 2022

honno deleted the indexing-improvements branch February 28, 2024 13:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Index testing improvements #124

Index testing improvements #124

honno commented May 23, 2022 •

edited

Loading

honno commented May 23, 2022 •

edited

Loading

Index testing improvements #124

Index testing improvements #124

Conversation

honno commented May 23, 2022 • edited Loading

honno commented May 23, 2022 • edited Loading

honno commented May 23, 2022 •

edited

Loading

honno commented May 23, 2022 •

edited

Loading