Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test_iop fix: assign res to in-place operator function #130 #133

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

simonetgordon
Copy link
Contributor

@simonetgordon simonetgordon commented Jun 27, 2022

To resolve issue #130

@honno honno self-requested a review June 27, 2022 13:26
@asmeurer
Copy link
Member

This looks good. This probably didn't come up for NumPy because it actually does a mutation, but that is not a requirement of the spec. In Python, x op= y is equivalent to x = x.__iop__(y) (see https://docs.python.org/3/reference/datamodel.html?highlight=__iadd__#object.__iadd__).

@asmeurer asmeurer merged commit ddd3b7a into data-apis:master Jun 27, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants