Use hash when searching #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperkid123
reviewed
Dec 12, 2019
| @@ -54,7 +54,7 @@ const DocSearch = () => { | |||
| handleSelected: (input, event, suggestion) => { | |||
| event.button = 0; | |||
| const resultUrl = new URL(suggestion.url); | |||
| push(resultUrl.pathname); | |||
| push(`${resultUrl.pathname}${resultUrl.hash}`); | |||
There was a problem hiding this comment.
what if the hash is undefined?
There was a problem hiding this comment.
Well that depends on the algolia crawler. We are not in control here
rvsia
force-pushed
the
router-uses-hash
branch
from
2aa41b3 to
05e5756
Compare
Hyperkid123
approved these changes
Dec 12, 2019
|
🎉 This PR is included in version 1.23.7 🎉 The release is available on Demo can be found here! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appends hash to algolia suggestions.