-
Notifications
You must be signed in to change notification settings - Fork 770
feat(geo): support geometry type for create table #14615
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
we may need install deps for build bounded proj in our ci container. cc @everpcpc I add the deps for |
I think it should be supported only if it's stable to avoid incompat problem. |
443e158
to
02c25ae
Compare
parse As @lnicola kindly point out the
FYI: Snowflake support these types of point. |
See also georust/geo#797 |
@b41sh PTAL again when you have time. Happy Spring Festival:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix the ci tests.
7120920
to
96913d9
Compare
![]() I have finished the static linking, but the tests still failed (can pass on my machine), and builds for aarch64 and python binding are not successful. @everpcpc need your help. |
|
340c8bc
to
0d23dc7
Compare
@everpcpc and I have tried various methods diligently this week, but still haven't completely solved the compilation problem of Proj. The current status is:
Therefore, we temporarily commented out the functions that depend on Proj implementation so we can merge this PR first. We may need more work to complete the compilation of Proj. cc @BohuTANG @sundy-li @kkk25641463 @cdmikechen |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Support geometry type for create table and add two new geometry functions.
If use
bendsql
, need this patch databendlabs/bendsql#352part of #14543
Tests
Type of change
This change is