Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Relax pyarrow pin #389

Merged
merged 3 commits into from
May 29, 2024
Merged

Relax pyarrow pin #389

merged 3 commits into from
May 29, 2024

Conversation

dhirschfeld
Copy link
Contributor

@dhirschfeld dhirschfeld commented Apr 26, 2024

Arrow 15 has been released and it woudl be good to be able to use it.

https://arrow.apache.org/blog/2024/01/21/15.0.0-release/


Resolves #390

@kravets-levko
Copy link
Contributor

Hi @dhirschfeld! Thank you for contributing! I should ask you to do two things before we can proceed:

  • please sign off your commits. To fix existing comits in this branch - use git rebase -i main
  • please update poetry.lock file as well using poetry lock command

@dhirschfeld
Copy link
Contributor Author

please sign off your commits

In the linked docs it says:

you can sign your commit automatically with git commit -s

...but my commits are cryptographically signed, so do I still need the Signed-off-by: footer?

image

Signed-off-by: Dave Hirschfeld <dave.hirschfeld@gmail.com>
Signed-off-by: Dave Hirschfeld <dave.hirschfeld@gmail.com>
Signed-off-by: Dave Hirschfeld <dave.hirschfeld@gmail.com>
@dhirschfeld
Copy link
Contributor Author

@kravets-levko - the commits should all be signed off now...

@dhirschfeld
Copy link
Contributor Author

ping @kravets-levko - any objections?

@susodapop
Copy link
Contributor

...but my commits are cryptographically signed, so do I still need the Signed-off-by: footer?

Hey @dhirschfeld this is a bit tangential to your PR but in case your curious: the cryptographic signing and the Signed-off-by commit text actually serve different purposes. The "verified" badge verifies that it was your computer that generated the code. Whereas the Signed-off-by header is more about legal attribution. The "verified" header is nice to have but not required by this repository. The Signed-off-by is mandatory to protect the maintainers from legal challenges if someone attempts to commit code to this repository that they weren't authorized to open-source.

@susodapop
Copy link
Contributor

Note that this PR will also close #390

Copy link
Contributor

@susodapop susodapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this passes the automated e2e tests this looks good to merge.

@kravets-levko kravets-levko merged commit 6949aba into databricks:main May 29, 2024
11 checks passed
@dhirschfeld dhirschfeld deleted the patch-1 branch May 29, 2024 10:53
@arredond arredond mentioned this pull request Oct 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loosen, update, or widen pyarrow dependencies
3 participants