[PECO-921] (Reimplemented) Fix: allow DESCRIBE TABLE EXTENDED to handle more than 2048 characters #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
temporarily deployed
to
azure-prod-peco
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-pecou
GitHub Actions
Inactive
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
temporarily deployed
to
azure-prod-peco
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-pecou
GitHub Actions
Inactive
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
temporarily deployed
to
azure-prod-pecou
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-peco
GitHub Actions
Inactive
benc-db
reviewed
Aug 2, 2023
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
temporarily deployed
to
azure-prod-pecou
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-peco
GitHub Actions
Inactive
benc-db
reviewed
Aug 2, 2023
| self.assertEqual(get_identifier_list_string(table_names), "*") | ||
|
|
||
| def test_describe_table_extended_may_limit(self): | ||
| """GIVEN a list of table_names whos total character length does not 2048 characters |
There was a problem hiding this comment.
When we tackle improving our tests, we should discuss how we want to encode this information. I tend to favor encoding in the test name in python, but mainly because I haven't come across a test framework in python that did a great job of it.
benc-db
approved these changes
Aug 2, 2023
susodapop
pushed a commit
that referenced
this pull request
Aug 29, 2023
…le more than 2048 characters (#405) --------- Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
|
@benc-db / @susodapop would it be possible to create a 1.5 backport patch? |
What is blocking you/your customer from using 1.6.x? |
|
@colin-rogers-dbt Included in 1.5.6 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #325
Description
Follow-on work after we reverted the original fix in #404.
The behaviour is now gated behind an environment variable called
DBT_DESCRIBE_TABLE_2048_CHAR_BYPASS. When that environment variable is set totruethen the fix is applied. Else we do not cap the joined table names length to 2048 characters. This 2048 limit only applies to Glue Catalog users and should not be applied to all dbt runs.Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.