Allow clustering of a nested path #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
Dec 29, 2023
| 'texts': [ | ||
| { | ||
| 'text': 'Can you provide a short summary of the following text', | ||
| 'text_cluster': {'cluster_id': 0, 'membership_prob': 1.0, 'topic': 'summarization'}, |
There was a problem hiding this comment.
for my understanding where does "_cluster" come from? maybe this should be text.cluster if auto-gen
There was a problem hiding this comment.
let's avoid having periods because that makes it unclear if cluster is a child of text, or a column name with a dot in it. If we do a "dot", we will now forever have to escape it with double quotes in order to select that field in text form
select_rows(['texts.*."text.cluster"']) vs simply select_rows(['texts.*.text_cluster']). Obviously a tuple will work, but the correct tuple will be tricky to write when using public api in notebooks.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clustering of
something.*.*is not yet supported. The path must end in a field name for now.