Add exclude_signals to select_rows, and include_signals to export methods. #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dsmilkov
reviewed
Jan 26, 2024
lilac/data/dataset_duckdb.py
Outdated
| @@ -2640,7 +2666,7 @@ def _column_to_duckdb_paths( | |||
| is_petal = schema.get_field(path).dtype is not None | |||
|
|
|||
| # NOTE: The order of this array matters as we check the source and map manifests for fields | |||
| # before reading signal manifests, via source_or_map_has_path. | |||
| # before reading signal manifests, via source_or_map_has_path.s | |||
dsmilkov
reviewed
Jan 26, 2024
| length_signal = LengthSignal() | ||
| dataset.compute_signal(length_signal, 'text') | ||
|
|
||
| result = dataset.select_rows(combine_columns=True, exclude_signals=True) |
There was a problem hiding this comment.
can you add a test where you select explicitly just a single sub-field of a signal (via columns, but exclude_signals=True)
dsmilkov
approved these changes
Jan 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation here is for export methods to quickly allow disabling signals for exporting.
select_rowsnow hasexclude_signals, which automatically disables signals.to_*now haveinclude_signals, which by default removes signals. If you set this to true, you will get signals on the other side.Also add a cluster sampling notebook that shows this workflow.