Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Respect the self._split param when computing embeddings for a text #1193

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Respect the self._split param when computing embeddings for a text #1193

merged 3 commits into from
Feb 27, 2024
+59 −27

Conversation

dsmilkov
Copy link
Collaborator

  • When we sync a concept database with a concept model, we need to compute embeddings without chunking.
  • Fix occasional undefined is not iterable js bug in the ItemMediaTextContent
  • Remove "apply to dataset" in concept view, since the labeler has a "go to dataset" button

@dsmilkov dsmilkov requested review from nsthorat and brilee February 27, 2024 14:50
@dsmilkov dsmilkov enabled auto-merge (squash) February 27, 2024 14:59
@dsmilkov dsmilkov merged commit 50d4a88 into main Feb 27, 2024
4 checks passed
@dsmilkov dsmilkov deleted the ds-fix-chunker branch February 27, 2024 15:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nsthorat nsthorat nsthorat approved these changes

@brilee brilee brilee approved these changes

Assignees
No one assigned
Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsmilkov @nsthorat @brilee