Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Multiple bug fixes and enhancements for std regex #256

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

stephenamar-db
Copy link
Collaborator

Implement namedGroups (which was missing from the first implementation)

  • JS is tricky because you need to convert Python-style named groups (the only ones supported by RE2) to perl ones
  • You need to manually find them due to the lack of clear API in the JDK

Align our implementation with jrsonnet implementations:

  • return null if no match
  • make fullmatch just partialmatch with anchors - it also allows us to share more code.

Fix the - problem with regexQuote in RE2 across the board

@stephenamar-db stephenamar-db marked this pull request as ready for review January 3, 2025 19:05
@stephenamar-db
Copy link
Collaborator Author

@JoshRosen at your convenience

@stephenamar-db stephenamar-db merged commit 9143c58 into master Jan 7, 2025
6 checks passed
@stephenamar-db stephenamar-db deleted the cleanip branch January 7, 2025 23:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants