Skip to content

Prune sqlglot transpiler and customization #1452

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

ericvergnaud
Copy link
Contributor

With the release of Morpheus and remorph-community-transpiler, remorph no longer requires its sqlglot-based transpiler and corresponding customizations.
This PR drops the corresponding code and related tests.

Copy link

github-actions bot commented Feb 18, 2025

✅ 3/3 passed, 3s total

Running from acceptance #108

@ericvergnaud
Copy link
Contributor Author

@sundarshankar89 I might need your help to debug the failing integration tests

@sundarshankar89
Copy link
Collaborator

@ericvergnaud Can you split this PR with code changes and then separate PR to remove the test examples SQL.
That way it is easier to Review.

@sundarshankar89
Copy link
Collaborator

The integration tests are failing as expected because we use custom dialects for our Reconcile target code generation and transformation.

@ericvergnaud
Copy link
Contributor Author

The integration tests are failing as expected because we use custom dialects for our Reconcile target code generation and transformation.

I would expect this to also fail corresponding unit tests ?

@sundarshankar89
Copy link
Collaborator

The integration tests are failing as expected because we use custom dialects for our Reconcile target code generation and transformation.

I would expect this to also fail corresponding unit tests ?

We had this conversation when this was all originally under unit and moved over to integration. few tests are unit and few really depend on spark infra.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants