-
Notifications
You must be signed in to change notification settings - Fork 38
Prune sqlglot transpiler and customization #1452
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
✅ 3/3 passed, 3s total Running from acceptance #108 |
@sundarshankar89 I might need your help to debug the failing integration tests |
@ericvergnaud Can you split this PR with code changes and then separate PR to remove the test examples SQL. |
The integration tests are failing as expected because we use custom dialects for our Reconcile target code generation and transformation. |
I would expect this to also fail corresponding unit tests ? |
We had this conversation when this was all originally under unit and moved over to integration. few tests are unit and few really depend on spark infra. |
With the release of
Morpheus
andremorph-community-transpiler
,remorph
no longer requires itssqlglot
-based transpiler and corresponding customizations.This PR drops the corresponding code and related tests.