Extend Support for Dependency Management #1512
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ 13/15 passed, 2 failed, 1 skipped, 51s total ❌ test_run_python_dep_failure_pipeline: assert 'Script execution failed' in "Failed to install dependencies: ERROR: Invalid requirement: 'databricks_labs_ucx=0.1.0': Expected end or semicolon (after name and no valid version specifier)\n databricks_labs_ucx=0.1.0\n ^\nHint: = is not a valid operator. Did you mean == ?\n" (13.035s)❌ test_run_pipeline: AssertionError: Step usage_2 failed with status SKIPPED (22.897s)Running from acceptance #570 |
| @@ -60,6 +71,12 @@ def test_run_python_failure_pipeline(extractor, python_failure_config, get_logge | |||
| pipeline.execute() | |||
|
|
|||
|
|
|||
| def test_run_python_dep_failure_pipeline(extractor, pipeline_dep_failure_config, get_logger): | |||
There was a problem hiding this comment.
I think it makes sense to fail the entire Step if one of the dependencies cannot be installed. Out of curiosity, do you think that this should fail the entire Pipeline execution run too?
| @@ -26,3 +26,6 @@ steps: | |||
| mode: overwrite | |||
| frequency: daily | |||
| flag: active | |||
| dependencies: | |||
| - pandas | |||
| - duckdb | |||
There was a problem hiding this comment.
Maybe we can add a test for a dependency with a version specified as well?
There was a problem hiding this comment.
Let me check.
sundarshankar89
changed the title
asnare
reviewed
Apr 17, 2025
There was a problem hiding this comment.
Looking good, I've left a few comments for consideration.
One thing I considered was whether we should skip the virtual environment if there aren't any dependencies, but it turns out that this also avoids a quirk prior to this PR where you don't know exactly what python refers to when executing a step. (And now we do.)
| except json.JSONDecodeError: | ||
| logging.info(f"Python script output: {result.stdout}") | ||
|
|
||
| except CalledProcessError as e: |
There was a problem hiding this comment.
It looks like upon failure we drop anything that was written to stdout. Do you think it's useful to log that?
| @@ -22,6 +22,17 @@ def pipeline_config(): | |||
| return config | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="module") | |||
There was a problem hiding this comment.
I'm curious about why this is needed?
There was a problem hiding this comment.
you mean the scope variable?
sundarshankar89
changed the base branch from
main
to
feature/synapse-cred-configuration
…o feature/pipeline_extensions
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Support for Dependency Management while executing pipeline with python file.