fix validation for UpdateOperatorsMessage

Signed-off-by: Jun Kimura <jun.kimura@datachain.jp>
datachainlab · Jun 17, 2024 · 74087d4 · 74087d4
1 parent 3c28b50
commit 74087d4
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/light-clients/lcp/types/header.go b/light-clients/lcp/types/header.go
@@ -86,6 +86,9 @@ func (m UpdateOperatorsMessage) ValidateBasic() error {
 	if m.NewOperatorsThresholdDenominator == 0 {
 		return fmt.Errorf("new operators threshold denominator cannot be zero")
 	}
+	if m.NewOperatorsThresholdNumerator > m.NewOperatorsThresholdDenominator {
+		return fmt.Errorf("new operators threshold numerator cannot be greater than denominator")
+	}
 	if len(m.Signatures) == 0 {
 		return fmt.Errorf("signatures cannot be empty")
 	}