Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UI tweaks #452

Merged
merged 8 commits into from
Feb 5, 2025
Merged

UI tweaks #452

merged 8 commits into from
Feb 5, 2025

Conversation

codycooperross
Copy link
Contributor

Purpose

A series of small interface tweaks that address a few standing issues. See issues below; additionally, 1) makes Checking claim status button primary variant while loading to improve consistency and 2) makes Repository sidebar button styling uniform and with spacing.

closes: https://github.com/datacite/product-backlog/issues/139 https://github.com/datacite/product-backlog/issues/135

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Copy link

cypress bot commented Feb 5, 2025

akita    Run #1544

Run Properties:  status check passed Passed #1544  •  git commit 04af9ce424 ℹ️: Merge fe971a70897af601fdfe25d5e779e808af5d00a4 into 6c3bba88441e5b5611493b97934b...
Project akita
Branch Review ui-tweaks
Run status status check passed Passed #1544
Run duration 01m 34s
Commit git commit 04af9ce424 ℹ️: Merge fe971a70897af601fdfe25d5e779e808af5d00a4 into 6c3bba88441e5b5611493b97934b...
Committer codycooperross
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 50
View all changes introduced in this branch ↗︎

@codycooperross codycooperross merged commit a07a89b into master Feb 5, 2025
12 checks passed
@codycooperross codycooperross deleted the ui-tweaks branch February 5, 2025 13:40
Copy link

cypress bot commented Feb 5, 2025

akita    Run #1546

Run Properties:  status check passed Passed #1546  •  git commit a07a89b3f2: Merge pull request #452 from datacite/ui-tweaks
Project akita
Branch Review master
Run status status check passed Passed #1546
Run duration 01m 43s
Commit git commit a07a89b3f2: Merge pull request #452 from datacite/ui-tweaks
Committer codycooperross
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 50
View all changes introduced in this branch ↗︎

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants