Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove notify slack from the git workflow #24

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

ashwinisukale
Copy link
Contributor

@ashwinisukale ashwinisukale commented Feb 1, 2024

Purpose

We have not set Notify Slack properly, it is breaking the build, hence removing it as we removed from other repositories.
closes: #23

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@ashwinisukale ashwinisukale self-assigned this Feb 1, 2024
@ashwinisukale ashwinisukale requested a review from a team February 1, 2024 07:58
@ashwinisukale ashwinisukale merged commit 98ff610 into master Feb 1, 2024
1 check passed
@ashwinisukale ashwinisukale deleted the remove_slack_notify branch February 1, 2024 08:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove notify slack from the deployment flow
2 participants