Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

remove optional flag from --dbt dependencies #544

Merged

Conversation

dlawin
Copy link
Contributor

@dlawin dlawin commented May 3, 2023

Resolves #526
Resolves #525

Makes the following packages non-optional:

dbt-artifacts-parser = {version="^0.2.5"}
dbt-core = {version="^1.0.0"}

The intent is to simplify installation for --dbt users.

We can tell folks to pip install data-diff, and they will be prompted with a single instruction for their database provider vs. the current two. Something like:
Screenshot 2023-05-03 at 2 23 51 PM

This will increase the number of required dependencies

@dlawin dlawin self-assigned this May 3, 2023
@dlawin dlawin requested review from pik94, nolar and vvkh May 3, 2023 19:10
@dlawin dlawin added enhancement New feature or request --dbt Issues/features related to the dbt integration labels May 3, 2023
@dlawin dlawin marked this pull request as ready for review May 3, 2023 19:11
@dlawin
Copy link
Contributor Author

dlawin commented May 3, 2023

this would essentially revert #412

@leoebfolsom
Copy link
Contributor

BQ & Databricks?

@dlawin
Copy link
Contributor Author

dlawin commented May 3, 2023

BQ & Databricks?

We could add those as well, the only reason I excluded is that they are not listed as dependencies at all currently (not even as optional ones)

@leoebfolsom
Copy link
Contributor

We could add those as well, the only reason I excluded is that they are not listed as dependencies at all currently (not even as optional ones)

Got it--I just want to make sure users of BQ and Databricks are able to get started with the same ease as the other DBs you listed, and they don't have to run these commands (which are currently listed in the documentation):

  • pip install data-diff 'data-diff[dbt]' google-cloud-bigquery
  • pip install data-diff 'data-diff[databricks,dbt]' -U

@nolar nolar mentioned this pull request May 5, 2023
This was referenced May 5, 2023
@dlawin dlawin force-pushed the daniel-dx-670-simplify-data-diff-installation branch from f99633a to 9914a6d Compare May 11, 2023 17:33
@dlawin dlawin merged commit e656160 into datafold:master May 11, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
--dbt Issues/features related to the dbt integration enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several dependencies being "Extras" makes installation complex "could not import 'dbt' package" error is confusing
3 participants