Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

support "port" in oracle connection #548

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

qsliu2017
Copy link

Currently, when oracle DSN is provided with a port, e.g. oracle://localhost:1234/db, the cx_Oracle driver will report

'port' is an invalid keyword argument for this function

Accordding to the docs, cx_Oracle support port in dsn parameter:

If the database is using a non-default port, it must be specified:

connection = cx_Oracle.connect(user="hr", password=userpwd,
                               dsn="dbhost.example.com:1984/orclpdb1",
                               encoding="UTF-8")

This PR parses port from data-diff into host of cx_Oracle, thus supports port number in oracle connection.

close #370

@qsliu2017
Copy link
Author

Hi there, will my PR be reviewed?

@skaosYan
Copy link

Hey! can someone review this PR?

@dlawin dlawin requested review from nolar and dlawin May 12, 2023 21:54
@dlawin dlawin added triage enhancement New feature or request labels May 12, 2023
Copy link
Contributor

@dlawin dlawin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense
Screenshot 2023-05-12 at 4 44 50 PM

Screenshot 2023-05-12 at 4 40 09 PM

@dlawin dlawin removed the triage label May 12, 2023
@dlawin dlawin merged commit 7ee154b into datafold:master May 15, 2023
@dlawin
Copy link
Contributor

dlawin commented May 15, 2023

Appreciate the contribution @qsliu2017 !

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oracle connection doesn't have a port number
3 participants