Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

fix KeyError exception for --json diffs #635

Merged
merged 2 commits into from
Jun 30, 2023
Merged

fix KeyError exception for --json diffs #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0e64c6
fix KeyError exception for --json diffs
vvkh Jun 30, 2023
b570f3f
Update data_diff/diff_tables.py
vvkh Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions data_diff/diff_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,7 @@ def get_stats_dict(self, is_dbt: bool = False):
"total": sum(diff_stats.diff_by_sign.values()),
"stats": self.stats,
}
if diff_stats.extra_column_diffs:
json_output["values"] = diff_stats.extra_column_diffs

json_output["values"] = diff_stats.extra_column_diffs or {}
return json_output


Expand Down
2 changes: 1 addition & 1 deletion tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def test_api_get_stats_dict(self):
"updated": 0,
"unchanged": 4,
"total": 1,
# "stats": {"rows_downloaded": 5},
"values": {},
}
t1 = connect_to_table(TEST_MYSQL_CONN_STRING, self.table_src_name)
t2 = connect_to_table(TEST_MYSQL_CONN_STRING, self.table_dst_name)
Expand Down