This repository was archived by the owner on May 17, 2024. It is now read-only.
Normalise all imports to fully qualified names #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlawin
reviewed
Sep 25, 2023
|
@nolar looks like some of the relative import updates are incorrect. See my comment above |
nolar
force-pushed
the
fully-qualified-imports
branch
from
bd4b6a3 to
6b0eef1
Compare
nolar
force-pushed
the
fully-qualified-imports
branch
from
6b0eef1 to
65754ab
Compare
dlawin
approved these changes
Sep 28, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use the same convention across the code (now: mixed relative & absolute imports).
Besides, this helps to easily grep the imports, so as to use IDEs features to auto-import modules on use.
Besides, the import sorters typically convert this to fully qualified names anyway.
THERE IS NO CHANGE IN FUNCTIONALITY.