add: dataservice admin page #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaudDauce
approved these changes
Oct 14, 2024
| <p class="fr-text--bold fr-my-3v"> | ||
| {{ t(`You haven't published a dataservice yet`) }} | ||
| </p> | ||
| <AdminPublishButton type="dataservice"/> |
There was a problem hiding this comment.
You need to add this type in AdminPublishButton otherwise it's disabled
There was a problem hiding this comment.
I propose to postpone this when #559 will be merged because publishing-form does not exist for dataservice in this PR.
...eme/gouvfr/assets/js/components/AdminTable/AdminDataservicesTable/AdminDataservicesTable.vue
Outdated
Show resolved
Hide resolved
maudetes
approved these changes
Oct 24, 2024
|
|
||
| export async function getDataservice(id: string) { | ||
| const res = await api.get<Dataservice>(`dataservices/${id}/`); | ||
| return res.data; | ||
| } | ||
|
|
||
| export async function getOrganizationDataservices(oid: string, page: number, pageSize: number, sortDirection: string) { | ||
| const resp = await api.get<PaginatedArray<Dataservice>>(getLocalizedUrl(`dataservices/`), { |
There was a problem hiding this comment.
I think private or deleted dataservices aren't fetched on this endpoint yet.
I think we need to apply the same logic on the backend as it has been done for reuses. Ticket created: datagouv/data.gouv.fr#1549
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.