feat(ingest): add rewrite option for metadata file check #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
reviewed
Aug 30, 2022
| is_flag=True, | ||
| help="Rewrite the JSON file to it's canonical form.", | ||
| ) | ||
| def metadata_file(json_file: str, rewrite: bool) -> None: |
There was a problem hiding this comment.
do you want to leave the old command in for backwards compat, with help text saying: "Deprecated: use metadata_file instead"?
There was a problem hiding this comment.
Given that we don't reference this command in our docs at all, my suspicion is that nobody was really using it (we really should have telemetry for cli commands by default). We can add the alias + deprecation warning, but I don't think it's necessary.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist