Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

perf(elastic search graph service): improving perf of lineage query #5858

Merged
merged 2 commits into from
Sep 7, 2022
Merged

perf(elastic search graph service): improving perf of lineage query #5858

merged 2 commits into from
Sep 7, 2022

Conversation

gabe-lyons
Copy link
Contributor

Moving the additional graph filters filter into each should query dramatically improved performance!

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

jjoyce0510
jjoyce0510 reviewed Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Overall LGTM!

@github-actions
Copy link

github-actions bot commented Sep 7, 2022 •
edited
Loading

Unit Test Results (build & test)

521 tests  ±0   521 ✔️ ±0   14m 22s ⏱️ -7s
122 suites ±0       0 💤 ±0 
122 files   ±0       0 ❌ ±0 

Results for commit f1b5dfe. ± Comparison against base commit f9917ea.

♻️ This comment has been updated with latest results.

@gabe-lyons gabe-lyons merged commit 86979e4 into datahub-project:master Sep 7, 2022
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@gabe-lyons @shirshanka
improving perf of filter query (datahub-project#5858)
8eb0fc0
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@gabe-lyons @shirshanka
improving perf of filter query (datahub-project#5858)
308c69e
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabe-lyons @RyanHolstien @jjoyce0510