Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(ingest): add entity type inference to mcpw #5880

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 9, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 44s ⏱️ +21s
   686 tests +1     683 ✔️ +1  3 💤 ±0  0 ±0 
1 372 runs  +2  1 366 ✔️ +2  6 💤 ±0  0 ±0 

Results for commit 1595ec5. ± Comparison against base commit e7b33c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Unit Test Results (build & test)

521 tests  ±0   521 ✔️ ±0   14m 20s ⏱️ - 1m 31s
122 suites ±0       0 💤 ±0 
122 files   ±0       0 ±0 

Results for commit 1595ec5. ± Comparison against base commit e7b33c5.

@anshbansal anshbansal added the ingestion PR or Issue related to the ingestion of metadata label Sep 10, 2022
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit e556bcb into datahub-project:master Sep 11, 2022
@hsheth2 hsheth2 deleted the mcpw-infer branch December 15, 2022 02:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants