Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(ingest): lookml - support for git checkout #5924

Merged
merged 6 commits into from
Sep 13, 2022

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 13, 2022
@shirshanka shirshanka requested a review from hsheth2 September 13, 2022 18:06
@github-actions
Copy link

github-actions bot commented Sep 13, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 3s ⏱️ +24s
   709 tests +1     706 ✔️ +1  3 💤 ±0  0 ±0 
1 418 runs  +2  1 412 ✔️ +2  6 💤 ±0  0 ±0 

Results for commit 73926fb. ± Comparison against base commit d1cfdf1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 13, 2022

Unit Test Results (build & test)

521 tests   - 50   515 ✔️  - 56   14m 7s ⏱️ -21s
122 suites  - 19       0 💤 ±  0 
122 files    - 19       6 +  6 

For more details on these failures, see this check.

Results for commit 73926fb. ± Comparison against base commit d1cfdf1.

This pull request removes 50 tests.
datahub.protobuf.ProtobufDatasetTest ‑ customFieldVisitors
datahub.protobuf.ProtobufDatasetTest ‑ duplicateNested
datahub.protobuf.ProtobufDatasetTest ‑ googleTimestamp
datahub.protobuf.ProtobufDatasetTest ‑ messageA
datahub.protobuf.ProtobufDatasetTest ‑ messageB
datahub.protobuf.ProtobufDatasetTest ‑ messageC
datahub.protobuf.ProtobufDatasetTest ‑ messageC2NestedOneOf
datahub.protobuf.ProtobufDatasetTest ‑ noSchemaTest
datahub.protobuf.ProtobufDatasetTest ‑ platformSchemaTest
datahub.protobuf.ProtobufUtilsTest ‑ registryTest
…

♻️ This comment has been updated with latest results.

@shirshanka shirshanka merged commit 15a33fa into datahub-project:master Sep 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants