Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(ingestion-ui) Use CLI version defined in recipe for test connection #5959

Conversation

chriscollins3456
Copy link
Collaborator

If there's a CLI version of ingestion set on this source, use that when running test connections. Otherwise continue to use the default as normal.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 15, 2022
@github-actions
Copy link

github-actions bot commented Sep 15, 2022

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 20s ⏱️ -7s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ±0 

Results for commit c8e88f8. ± Comparison against base commit f70bb20.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you!

@chriscollins3456 chriscollins3456 merged commit 461406a into datahub-project:master Sep 16, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants