feat(elastic-setup): add better error handling #5963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
pedro93
approved these changes
Sep 16, 2022
tomas-kubin
added a commit
to tomas-kubin/datahub
that referenced
this pull request
Sep 20, 2022
pedro93
added a commit
that referenced
this pull request
Sep 29, 2022
* refactor(elasticsearch-setup-job): create-indices.sh readability The script contains many copy-pasting and is not easy to follow. Add comments, extract commonly used operations into functions, unify approaches. * fix(elasticsearch-setup-job): AWS indices creation Fix the issue where Amazon OpenSearch (AWS ES) indices are incorrectly initialised and the Analytics screen shows errors only. * feat(elasticsearch-setup-job): configuration hint mention USE_AWS_ELASTICSEARCH env value if it seems it's set the wrong way * fix(elasticsearch-setup-job): silent curl * fix(elasticsearch-setup-job): better USE_AWS_ELASTICSEARCH hint * docs(elasticsearch-setup-job): index dropping explained - more comments - more defensive approach - index file renamed * fix(elasticsearch-setup-job): script fixes * merge(elasticsearch-setup-job): merging in PR #5937 * merge(elasticsearch-setup-job): merging in PR #5963 * merge(elasticsearch-setup-job): merging in PR #5975 Co-authored-by: Pedro Silva <pedro@acryl.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist