Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IMPR: split unit/integration test #1211

Open
yambottle opened this issue Mar 14, 2025 · 0 comments
Open

IMPR: split unit/integration test #1211

yambottle opened this issue Mar 14, 2025 · 0 comments
Labels
enhancement Indicates new feature requests

Comments

@yambottle
Copy link
Contributor

Improvement Request

Problem

Currently, datajoint-python pytest runs unit and integration test by default, which requires a DB

pytest --cov-report term-missing --cov=datajoint tests
# trying to connect to a DB, otherwise integration test would fail

so it actually needs runs in docker that comes with a DB container

docker compose --profile test up --quiet-pull --build --exit-code-from djtest djtest

Requirements

N/A

Justification

We should add unit test check in pre-commit locally, and let the CI to run integration test with docker

Alternative Considerations

N/A

Related Errors

N/A

Please include steps to reproduce provided errors as follows:
N/A

Screenshots

N/A

Additional Research and Context

N/A

@yambottle yambottle added enhancement Indicates new feature requests triage Indicates issues, pull requests, or discussions need to be reviewed for the first time stale Indicates issues, pull requests, or discussions are inactive and removed triage Indicates issues, pull requests, or discussions need to be reviewed for the first time stale Indicates issues, pull requests, or discussions are inactive labels Mar 14, 2025
@yambottle yambottle mentioned this issue Mar 14, 2025
21 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

1 participant