-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor to rdFingerprintGenerator #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's still draft, I can wait.
The tests are failing, probably due to the different set arguments in the fingerprint generators. |
Ok, will do. |
@zhu0619, the default parameters were wrong. They are fixed now. Still have to address this: danielfrg/mkdocs-jupyter#200 Ideally in the next release, we should also have a minimum version for rdkit. As the pandas error still exists. |
I also replaced seaborn by pure matplotllib in one of the notebook. Was getting an error and not sure how. Feel free to merge anytime. |
Changelogs
This PR addresses the fingerprint deprecation warnings, see issue #225.
ecfp-count
now use the ECFP-6, to stay consistent.dm.no_rdkit_log
which disable RDKit log for a whole function.Checklist:
feature
,fix
ortest
(or ask a maintainer to do it for you).The
rdFingerprintGenerator.GetCountFingerprint
can be used to compute the count based fingerprint.The argument
countSimulation
indicates whether to compute the count fingerprint by bites simulation for computing efficiency. See more in this blog.I assume in
datamol
, we want to compute the exact count-based fingerprint. Therefore,countSimulation
should be set to False.