Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Alternate ILoggerProvider-based logging API #269

Merged
merged 4 commits into from
Nov 30, 2016
Merged

Alternate ILoggerProvider-based logging API #269

merged 4 commits into from
Nov 30, 2016

Conversation

jorgebay
Copy link
Contributor

No description provided.

@landim
Copy link
Contributor

landim commented Nov 29, 2016

👍 Project used to test NLog integration > https://github.com/landim/csharp-driver-nlog-test

@jorgebay jorgebay merged commit c02b521 into master Nov 30, 2016
@jorgebay jorgebay deleted the CSHARP-171 branch November 30, 2016 10:56
@jorgebay
Copy link
Contributor Author

Merged! +1 on the test project

@PaulDMendoza
Copy link

We need to get rid of the package dependency this introduced because that package only supports .NET 4.5. It makes it impossible for .NET 4.5.1 and above projects to use the Nuget package for CassandraCSharpDriver. We've had to go back to using version 3.1.0.1 which is the last version where this worked.

@jorgebay
Copy link
Contributor Author

@PaulDMendoza Microsoft.Extensions.Logging v1.0.0 and Microsoft.Extensions.Logging.Abstractions v1.0.0 support .NET Standard 1.1+ which includes .NET Framework 4.5, so it shouldn't be a problem.

We tested on a fresh Windows Server 2012 r2 with .NET Framework 4.5 SDK only and it works without any issues. Maybe you are using an older version of the nuget client?

@PaulDMendoza
Copy link

.NET 4.5 is different and older than .NET 4.5.1. I was able to get it to work when I changed my assembly to use .NET 4.5 but I've got a bunch of applications that are already targeting .NET 4.5.1.

I am using Visual Studio 2013 on Windows 8. But that shouldn't really make a difference.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants