Release 17.0.0 #831
Merged
Release 17.0.0 #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional `diffSubtypes` to `IMultiSelectionAdapter` - Remove `ReprovisynMultiSelectionAdapter` - Add generics to `MultiSelectionAdapter` - Comment functions of `MultiSelectionAdapter`
Unecessary convoluted call
- Add and refactor return types `Promise<any>` to `Promise<void>` - Switch to async/await where possible - await `removeDynamicColumns` before `addDynamicColumns` -> previously it was not waited for the removal
* Added build-storybook to build script * Add tdp_core/dist alias to the storybook webpack config * updated version of storybook (#736) Co-authored-by: Moritz Heckmann <moritz.heckmann@datavisyn.io> Co-authored-by: dvmoritzschoefl <77104411+dvmoritzschoefl@users.noreply.github.com> Co-authored-by: Moritz Heckmann <moritz.heckmann@datavisyn.io>
Probably a missing type cast in PR #729
Waiting for `this.built` will never resolve/terminate and show an infite loading icon. Reason: `this.built` is created with `build()` in line 355 and it is only resolved after the `build()` call is complete. With the changes to the selection adapter the `this.selectionAdapter.selectionChanged` now returns a valid promise. Previously, `context.add()` did not return it's promise (see 919cfb2#diff-f0f07e4a6ac30a813315b152545245d4cf26830e01b701f3e82ff7b5c22363a7R18). Now, we are waiting until all dynamic columns are added. The circle closes when we add the columns which calls `withoutTracking()` which in-turn is waiting for the resolved `this.built` promise. As far as I can see, we always call `withoutTracking` on a built/resolved ranking view. In the other places (line 377 and 400) we have a dedicated `await this.built;` before triggering changes to dynamic columns. In my tests adding and removing columns via score and selection adapter worked as before. I also tested reloading the page and checked the result of the session. In all cases it looks the same as before.
Adjusted color mapping styles
* Cypress 11 and CI integration * Enable cypress in build.yml * Delete build_nightly.yml
…andas (#816) * Upgrade deps and remove numpy, numba, pandas * Replace BaseHTTPMiddleware with much faster ASGI equalivalent * Increase anyio threads to 100 * Remove broken etag support * Improved logging * Switch to a2wsgi * Remove a2wsgi again * Remove greenifier extension * Bump FastAPI to 0.89.0 * Add pytest in settings.json * Set SQLAlchemy version to >= 1.4.40 and <= 1.4.46 to allow SQLModel > 0.0.6 (#819) * Loosen Flask and marshmallow-sqlalchemy versions for superset * Removed flake8, isort, pep8 in favor of ruff
* upgrade webpack for storybook * use webpack.config from storybook and override rules * add HtmlWebpackPlugin * Fix storybook path aliases * use latest version of storybook Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io> Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
* enabled custom vis in lineup * Made idField optional Co-authored-by: Moritz Heckmann <moritz.heckmann@datavisyn.io> Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>
…786) Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com> Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>
changing name
fix(cypress): health check
* Improve visyn app with context, store awareness, ... * Make DummyStore a proper security store * Make Vis/Plotly lazy to strip off 10 MB of bundle size * Separate store id and ui id * Further improve header by removing unused props * Add back deprecated features like alwaysAppendDummyStore * Move plotly to own package * Added login popup to avoid losing site state
* converting vis component to mantine * moving sidebar into a drawer * finishing mantine conversion * bug fixing and cleanup * opening settings bar by default * adding hexbin back * adding clipping path to hexbins * fixing legend * importing vis in place in ARankingView * fixing small multiples hexbin * improving sorting speed * memoizing selection * moving packages to dev deps * adding visynApp components to core * adding dependencies * removing duplicate deps * fixing errors * removing duplicate import * debouncing slider callback * removing speed improvements (for future pr) * removing console logs * switch to debounced callback for hex slider * removing console logs * adding back scatter vis speed improvements * adding i18n * updating mantine -> peer dependencies * fixing colors bug * Remove mantine from peerDependencies * Add missing dist files * Add missing dist file * addressing pr feedback * small code fixes * added i18n for the button string * typing to any to fix plotly problem * fixing plotly type error * typing all of the layouts to any * fixing small bugs * cleaning up a lot of bad logic in hexbin * removing unnecessary logic * changed selection to be more consistent with scatterplot * improving selection consistency * more selection improvements * make categories scrollable * adding i18n * fixing error message * Fix sentence case in vis * bug fixing * moving x * fixing bugs * fixing typings, hexbin bug * linting * updating stories * small code changes * fixing pan reset problem * adding layout changes everywhere * solving bugs * fixing hexbin sidebar problem * Run `yarn run all` * bug fixing * linting * bug fixing * testing * bug fixing * removing prints * switching back to horizontal * making scroll zooming work * removing strip plots * removing prints * linting * Remove commented out code and console log * Add missing dist files * hiding setting button when sidebar disabled * moving gear icon to front * allowing domains to be set for numerical columns * cleaning up * linting * allowing undefined in domain * cleaning * fixing bug * bug * fixed axis domain bug --------- Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>
puehringer
approved these changes
Feb 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Release dependencies first
In case of dependent Phovea/TDP repositories follow dependency tree from the top:
🏁 Finish line