Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

replace with quick-protobuf #2

Open
yoshuawuyts opened this issue Apr 7, 2018 · 4 comments · Fixed by #8
Open

replace with quick-protobuf #2

yoshuawuyts opened this issue Apr 7, 2018 · 4 comments · Fixed by #8

Comments

@yoshuawuyts
Copy link
Collaborator

yoshuawuyts commented Apr 7, 2018 •
edited
Loading

pure Rust & faster, means we can use it inside WASM / port it more easily https://github.com/tafia/quick-protobuf
@yoshuawuyts
Copy link
Collaborator Author

This one looks good too! https://github.com/danburkert/prost

@bltavares
Copy link
Member

Given that https://github.com/stepancheg/rust-protobuf/ is written in pure rust according to the README, is there still a reason to change the lib?

bltavares added a commit to bltavares/dat-network-protocol that referenced this issue Jan 22, 2020
@bltavares
Migrate codegen to pure-rust generator
50d68e3 
This commit replaces the build.rs dev dependency to generate protobuf
files using a pure-rust implementation, removing the requirement to have
`protoc` installed and making it easier to contribute.

This commit also bumps the lib protobuf lib to the latest version, and pin it
to a specific dependency, as required by the constant it generates. Due
to requiring a specific protobuf version, a new minor version has been
bumped.

Tentatively fix datrs#2
@bltavares bltavares mentioned this issue Jan 22, 2020
Merged
3 tasks
@Frando
Copy link
Member

Frando commented Jan 24, 2020

One thing is that the structs created by quick-protobuf (or Prost, but that uses protoc still) are much leaner and lighter than the ones created by rust-protobuf.

@bltavares bltavares reopened this Feb 19, 2020
@bltavares
Copy link
Member

While the crate now uses a pure-rust lib, there is still an opportunity to improve the generated crates. I'll keep the issue opened.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate codegen to pure-rust generator bltavares/dat-network-protocol
3 participants
@Frando @bltavares @yoshuawuyts