Fixes #7: Make RandomAccess always open #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This was referenced Aug 27, 2018
|
See the necessary changes to the dependent libs: datrs/random-access-disk#13, datrs/random-access-memory#4, datrs/hypercore#26 |
khernyo
force-pushed
the
random-access-always-open
branch
from
1ff52f5 to
267171b
Compare
khernyo
changed the title
Signed-off-by: Szabolcs Berecz <szabolcs.berecz@gmail.com>
Signed-off-by: Szabolcs Berecz <szabolcs.berecz@gmail.com>
khernyo
force-pushed
the
random-access-always-open
branch
from
267171b to
c2ce3d9
Compare
yoshuawuyts
approved these changes
Aug 28, 2018
|
All right, it's good to go. Please merge this and release a new version so that I can reference it in the other two random-access projects. I will do the cleanup on the other PRs tomorrow. |
|
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
open()method and the now redundantRandomAccessstruct.This does not follow exactly #7 as there is no new struct/trait for the unopened state. It turns out that adding that would complicate things for no benefit IMO.
Checklist
Context
#7
Semver Changes
Minor