New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change missing from 0 to NaN #20

Merged

davechallis merged 1 commit into davechallis:master from vbkaisetsu:patch-2

Feb 2, 2024

Contributor

vbkaisetsu commented Dec 29, 2023

This branch changes the value of the missing argument from 0 to NaN to match the default behavior of the Python front end.
https://github.com/dmlc/xgboost/blob/a197899161fa70e681101de4232745fdfe737804/python-package/xgboost/core.py#L843


          Change missing from 0 to NaN

vbkaisetsu mentioned this pull request

Use f32::NAN as a missing value postgresml/rust-xgboost#8

Merged

montanalow commented Dec 29, 2023

@vbkaisetsu inspired me to update our branch after his contribution. This is included in #21

davechallis merged commit 296cf9e into davechallis:master

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet