WIP: ENHANCEMENT - YouTubeDL-Material - add UID/GID env options #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2022 14:10
bcurran3
changed the title
davestephens
requested changes
Aug 22, 2022
There was a problem hiding this comment.
What the dev thinks the uid/gid is not relevant in this context. It needs to be set to either 0 for root, or the uid/gid for the ansible Nas user needs to be calculated and used. Depends on the desired behaviour.
In Ubuntu uid/gid 1000 is the first user added user, ie likely you, which is definitely not the right one.
| @@ -9,6 +9,10 @@ youtubedlmaterial_dl_audio_directory: "{{ downloads_root }}/youtube/audio" | |||
| youtubedlmaterial_dl_video_directory: "{{ downloads_root }}/youtube/video" | |||
| youtubedlmaterial_dl_subscriptions_directory: "{{ downloads_root }}/youtube/subscriptions" | |||
|
|
|||
| # uid / gid | |||
| youtubedlmaterial_user_id: "1000" | |||
There was a problem hiding this comment.
This doesn't look right to me.
| @@ -9,6 +9,10 @@ youtubedlmaterial_dl_audio_directory: "{{ downloads_root }}/youtube/audio" | |||
| youtubedlmaterial_dl_video_directory: "{{ downloads_root }}/youtube/video" | |||
| youtubedlmaterial_dl_subscriptions_directory: "{{ downloads_root }}/youtube/subscriptions" | |||
|
|
|||
| # uid / gid | |||
| youtubedlmaterial_user_id: "1000" | |||
| youtubedlmaterial_group_id: "1000" | |||
| @@ -28,6 +28,8 @@ | |||
| - "{{ youtubedlmaterial_port_http }}:17442" | |||
| env: | |||
| ALLOW_CONFIG_MUTATIONS: "true" | |||
| UID: " {{ youtubedlmaterial_user_id }}" | |||
There was a problem hiding this comment.
Unintentional whitespace next to the uid/gid opening quotes
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
YouTubeDL-Material - add UID/GID env options
Not sure if the container supported this when I first added this to AN, but it does now. I left the defaults for UID/GID at the dev's defaults but now they can be overwridden.
Which issue (if any) this PR fixes:
Fixes #
Any other useful info:
I've had no success setting it to run as root:
It says "this is fine" but the container reboots. I have not tried setting to other UID's or GUD's, but now the option is there to play with. :->