Adding will_paginate support for total_entries being passed in as an option #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…option * In order to support a total_entries size different from the size of the collection we will need to pass the options all the way down to the WillPaginate::Collection#paginate method.
|
@davidcelis Let me know if there's any additional information you'd like me to provide. |
|
Sorry for the wait! Thanks ✨ |
|
Awesome! @davidcelis any plans on cutting a new release with these changes? |
|
Yup, just had to get back to my computer from a camping trip. 4.6.0 is out! |
|
FYI this change breaks existing usage for rendering json like so: As will paginate doesn't recognize the |
|
D'oh… I've just pushed a fix that will just additionally pass total_entries and will be releasing 4.6.1 in a sec. |
|
@davidcelis wonderful, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ApiPagination#paginate takes
options. These options are then part of paginating the collection using the WillPaginate::Collection#paginate method. Onlypageandper_pageused to be passed through all the way down to the will_paginate method. This PR makes sure that we simply pass through all options passed in.This specifically adds support for a total_entries size different from the size of the collection.