drop support for unmaintained versions of Node.js #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
commented
Jun 15, 2020
| @@ -1,5 +1,5 @@ | |||
| repo-owner = davidchambers | |||
| repo-name = doctest | |||
| author-name = David Chambers <dc@davidchambers.me> | |||
| source-files = lib/*.js | |||
| source-files = lib/*.js lib/*.mjs | |||
There was a problem hiding this comment.
I added lib/*.mjs to source-files so that .mjs files are linted.
davidchambers
commented
Jun 15, 2020
Comment on lines
-17
to
+16
| .concat (['--', | ||
| path.resolve (__dirname, | ||
| '..', | ||
| 'lib', | ||
| 'command' + (esmSupported ? '.mjs' : '.js'))]) | ||
| .concat (['--', path.resolve (__dirname, '..', 'lib', 'command.mjs')]) |
There was a problem hiding this comment.
command.mjs can now always be used, so I deleted command.js. :)
davidchambers
commented
Jun 15, 2020
lib/command.mjs
Outdated
| }, 0); | ||
| }); | ||
| })).then (function(statuses) { | ||
| process.exit (Math.max.apply (Math, statuses)); |
There was a problem hiding this comment.
I made this change:
-process.exit (statuses.every (function(s) { return s === 0; }) ? 0 : 1);
+process.exit (Math.max.apply (Math, statuses));There was a problem hiding this comment.
This approach fails for []:
> Math.max.apply (Math, [])
-InfinityI will revert this change.
Avaq
approved these changes
Jun 16, 2020
davidchambers
force-pushed
the
disharmony
branch
from
b625a1b to
bb457e0
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to reviewing the changes, @Avaq, you could spend some time on this branch grepping for terms such as
esmandprocess.versionin case I missed something.