use ES6 syntax #125
Merged
use ES6 syntax #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
commented
Jun 17, 2020
lib/doctest.js
Outdated
Comment on lines
69
to
63
| common.sanitizeFileContents (fs.readFileSync (path, 'utf8')) | ||
| (fs.readFileSync (path, 'utf8') | ||
| .replace (/\r\n?/g, '\n') | ||
| .replace (/^#!.*/, '')) |
There was a problem hiding this comment.
I decided to duplicate this small amount of code to allow lib/common.js to be deleted. Template strings obviate the need for unlines, so sanitizeFileContents was the only remaining shared function.
davidchambers
commented
Jun 17, 2020
lib/doctest.js
Outdated
Comment on lines
126
to
108
| // iifeWrap :: String -> String | ||
| function iifeWrap(s) { | ||
| return 'void function() {\n' + indentN (2, s) + '}.call(this);'; | ||
| } | ||
| // arrowWrap :: String -> String | ||
| const arrowWrap = s => `void (() => {\n${indentN (2, s)}})();`; |
There was a problem hiding this comment.
Do you see any reason not to use an immediately invoked arrow function rather than an immediately invoked function expression?
davidchambers
commented
Jun 17, 2020
Comment on lines
-552
to
+533
| repr = '! ' + name + | ||
| (expected.message && message.replace (/^(?!$)/, ': ')); | ||
| repr = `! ${expected.message === '' ? name : either.value}`; |
There was a problem hiding this comment.
When we want to use the <name>: <message> format we can simply use `! ${either.value}`, since Error.prototype.toString uses this format.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every version of Node.js we now target supports ES6 features. This means we can now use arrow functions, template strings, and
constto simplify and improve the codebase.Strictly speaking this is a breaking change, due to changes to
--printoutput. In practice, though, users should be unaffected.Edit: This pull request now changes the JavaScript interface from
doctest (path, options)todoctest (options) (path).