Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid writing uninitialized stack memory into INFO.ind and LEARN.ind #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmwiedemann
Copy link

(probably required because compilers do padding on structs)
in order to make package builds reproducible
See https://reproducible-builds.org/ for why this is good

I could not find a way to contribute this patch to upstream LiE,
so I'm sending it here in the hope that it will be useful
and eventually find its way to upstream.

Also tracked at https://bugzilla.opensuse.org/show_bug.cgi?id=1061220

(probably required because compilers do padding on structs)
in order to make package builds reproducible
See https://reproducible-builds.org/ for why this is good
@davidsd
Copy link
Owner

davidsd commented Oct 2, 2017

Thanks for the pull request! I should say that 1) I've had no communication with the upstream LiE developers, 2) this repository also has not been maintained in a while, and 3) the copy of LiE contained herein has been somewhat modified. So I'd recommend trying elsewhere if you want to get things merged upstream.

@bmwiedemann
Copy link
Author

bmwiedemann commented Oct 2, 2017

I don't know where 'elsewhere' would be, so I would just push it into openSUSE then.

  1. probably does not matter, because the patch applies cleanly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants