Mass-assignment can work with a stringified hash

[tatey]

Hello,

We came across an issue where mass assigning a stringified hash of attributes would raise a KeyError if any of those attributes were uninitialized on the object that mixes in ShallowAttributes.

Example:

class MainUser
  include ShallowAttributes
  attributes :age, Integer
end

u = MainUser.new
u.attributes # {}
u.attributes = {"age" => 21} # => KeyError

And this is the type of error you would get:

ShallowAttributes::#attributes=#test_0003_sets attributes which have not been initialized:
RuntimeError: can't add a new key into hash during iteration
    /shallow_attributes/lib/shallow_attributes/class_methods.rb:105:in `age='
    /shallow_attributes/lib/shallow_attributes/instance_methods.rb:207:in `block in define_attributes'
    /shallow_attributes/lib/shallow_attributes/instance_methods.rb:206:in `each'
    /shallow_attributes/lib/shallow_attributes/instance_methods.rb:206:in `define_attributes'
    /shallow_attributes/lib/shallow_attributes/instance_methods.rb:90:in `attributes='
    /shallow_attributes/test/shallow_attributes_test.rb:121:in `block (3 levels) in <top (required)>'

The reason we get this error is because of how we use ShallowAttributes with our form objects.

1. The form object is built in a before_action and then we update the form object with the POST data.
2. We perform mass assignment with a stringified hash (It's actually ActionController::StrongParameters) rather than a symbolized hash.

This patch changes the behaviour to make mass assignment work with both stringified and symbolized hashes. Given to_sym on symbols is a no-op there should be minimal overhead to projects using symbolized hashes.

Happy to have any feedback 😄

Cheers,
Tate

[coveralls]

Coverage increased (+0.007%) to 99.26% when pulling de185d3 on fivegoodfriends:fix-mass-assignment-with-uninitialized-attributes into 141489a on davydovanton:master.

[coveralls]

Coverage increased (+0.007%) to 99.26% when pulling de185d3 on fivegoodfriends:fix-mass-assignment-with-uninitialized-attributes into 141489a on davydovanton:master.

[davydovanton]

Looks perfect! I'll merge this changes after CI 👍

[davydovanton]

thanks!

[tatey]

Appreciate you merging @davydovanton. Would you mind cutting a new release? 😀

[tatey]

Bump? 😄

I'm happy to help if you need a hand.