Default values can be derived from private methods #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document default values can be private methods.
davydovanton
approved these changes
Nov 9, 2017
|
Glad you like the patch. A new release would be wonderful 😄 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This patch makes it so default values can be derived by private methods as well continuing to support public methods.
In our usage of ShallowAttributes we'd prefer to keep default values as private methods since they have no purpose beyond initailization. We have found you can still test these methods indirectly by testing initialization.
All feedback welcome.
Cheers,
Tate