Fix inheriting from a base class that does not define any attributes. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatey
commented
Mar 15, 2017
| # | ||
| def inherited(subclass) | ||
| super | ||
| if respond_to?(:default_values) |
There was a problem hiding this comment.
Given ShallowAttributes is intended to be a mixin we can't be certain that the base class will implement default_values. That's why it's necessary for us to check first.
tatey
commented
Mar 15, 2017
| @@ -66,8 +74,7 @@ def attributes | |||
| def attribute(name, type, options = {}) | |||
| options[:default] ||= [] if type == Array | |||
|
|
|||
| @default_values ||= {} | |||
| @default_values[name] = options.delete(:default) | |||
| default_values[name] = options.delete(:default) | |||
There was a problem hiding this comment.
As an added benefit to using the injection hook default_values is now a getter that always returns a hash.
|
Hey, |
|
Glad you like it 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Firstly, thank you for creating this project 😄. We are using it for our non-ActiveRecord backed forms.
We have a base class that mixes in
ShallowAttributes, but doesn't define attributes of its own. Any engineer can subclass this base class and have confidence that it will work out of the box in our forms and controllers.Unfortunately we hit a bug where the subclass would raise
TypeError: no implicit conversion of nil into Hashbecause it's trying to readdefault_valuesfrom a nil object which it expected to be a hash.We have managed to work around it by defining
MyExampleBaseClass.default_valuesto return an empty hash. While this is satisfactory it means the out of box experience withShallowAttributesis not as smooth as it could be.I hope you find this patch valuable and I'm open to any feedback you have.
Cheers,
Tate