Initializer can take stringified hashes #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
ShallowAttributes
work out of the box withActionController::StrongParameters
. The motivations for this patch are:ShallowAttributes
expects to work with symbolized hashes, butparameters
in Rails are stringified hashes.We were working around 2 by calling
params.to_h.symbolize_keys
before passing it to the initializer. This made the API feel a little rough and gave me the motivation to write this patch.You'll notice I used
#each_pair
over#each_with_object
or#reduce
. This is the only public method that is available on bothHash
andActionController::StrongParameters
which lets us symbolize the hash.I'm aware you may be opposed to the patch because it creates a new object and uses
#each_pair
. If you are opposed then I am open to exploring other options to make a great out of the box Rails experience.Either way let me know. All feedback welcome.
Cheers,
Tate