Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No Title Attribute on iFrame #20

Closed
JamieHughes93 opened this issue Oct 21, 2021 · 2 comments
Closed

No Title Attribute on iFrame #20

JamieHughes93 opened this issue Oct 21, 2021 · 2 comments

Comments

@JamieHughes93
Copy link

This editor doesn't allow for adding title attributes to the iframe accessibility purposes, it should at least display a generic "Video player" title. :)

@dawoe
Copy link
Owner

dawoe commented Oct 21, 2021

Hi @JamieHughes93

The embed code (iframe) is not generated by my package, but by a Umbraco Core functionality. I actually reuse the same dialog that you have in the core rich text editor for embedding. I have no control over it. But I will mark this as an idea so that it will make it easier to get the source from the generated iframe. That way you can generate your own iframe code.

@dawoe
Copy link
Owner

dawoe commented Jul 25, 2022

Hi @JamieHughes93

There is now an extension method added in 5.1.0 that allows you to get the src attribute of the iframe in the generated embed code. This will give you the option to write your own embed code.

Dave

@dawoe dawoe closed this as completed Jul 25, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants