Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UI improvements #5

Closed
ronaldbarendse opened this issue Sep 25, 2019 · 6 comments
Closed

UI improvements #5

ronaldbarendse opened this issue Sep 25, 2019 · 6 comments

Comments

@ronaldbarendse
Copy link

The current Add-button seems a bit off compared to other pickers:

Current add button

Changing it to be like this would look better:

New add button

Also, when only a single item can be selected, the drag-and-drop handle is still shown (maybe to move it over to another property?) and on smaller screens/larger previews, the Remove-button isn't (completely) shown:

afbeelding

@ronaldbarendse
Copy link
Author

And there's no background while dragging the item:

Dragging

@ronaldbarendse
Copy link
Author

And there's no background while dragging the item:

Dragging

Looks like this is a problem in Umbraco core, as I also see this when dragging document types in the Nested Content data type editor...

@dawoe
Copy link
Owner

dawoe commented Sep 25, 2019

Hi @ronaldbarendse

Thanks for the feedback. I will keep this open for a next version. I have seen some work being done in core to be able to edit embeds.

But if you are up to it... I accept pull requests 😄

@TRexStark
Copy link
Contributor

Hi @dawoe

I have styled the property in a test project I have and it looks like the below as an example. I can commit the files if you want to merge them.

There is a new stylesheet added and the view markup changed slightly

Screen Shot 2020-08-30 at 1 06 35 pm

@dawoe
Copy link
Owner

dawoe commented Aug 31, 2020

Hi @TRexStark

Could you make a PR for this. Looks awesome.

Dave

@dawoe
Copy link
Owner

dawoe commented Sep 26, 2020

This is fixed by #7

@dawoe dawoe closed this as completed Sep 26, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants