Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated the property's look and feel #7

Merged
merged 3 commits into from
Sep 26, 2020
Merged

Conversation

TRexStark
Copy link
Contributor

  • Added some styles to make the property editor look close to the Umbraco media picker property
  • Changed the "Add" button to become the link-square of the picker
  • Changed the "Remove" link to the cross look and feel and positioned it above and on top of the preview box
  • Re-positioned the sort icon/button to the top left of the preview box
  • Reduced the size of the preview box to the same height as the media picker property but the width at a ratio of an HD size proportionally
  • made all preview boxes as well as the "Add" button to align vertically
  • New styles are referenced from a new stylesheet which has been called from the package.manifest

- Added some styles to make the property editor look close to the Umbraco media picker property
- Changed the "Add" button to become the link-square of the picker
- Changed the "Remove" link to the cross look and feel and positioned it above and on top of the preview box
- Re-positioned the sort icon/button to the top left of the preview box
- Reduced the size of the preview box to the same height as the media picker property but the width at a ratio of an HD size proportionally
- made all preview boxes as well as the "Add" button to align vertically
- New styles are referenced from a new stylesheet which has been called from the package.manifest
@dawoe
Copy link
Owner

dawoe commented Sep 1, 2020

Hi @TRexStark

Thanks for the PR. I will try to find sometime this week to review it.

Stay tuned.

Dave

@dawoe
Copy link
Owner

dawoe commented Sep 14, 2020

Hi @TRexStark

Just wanted to let you know that I am a bit swamped with work lately, but I still have this on my radar.

Will try to review this one later this week.

Dave

@TRexStark
Copy link
Contributor Author

No worries @dawoe I'm planning to submit another Pull Request, I'm just testing it on a client site and will compile it hopefully later this week.

@dawoe
Copy link
Owner

dawoe commented Sep 22, 2020

Hi @TRexStark

First of all the updates look great. But I noticed some small issues when using it as a single picker.

image

It still shows the sorting icon and it shows a empty square box when a video is picked

Could you have a look at that ?

Dave

@dawoe dawoe self-assigned this Sep 22, 2020
@FransdeJong
Copy link

Is there a way to detect if it's in single mode in the view? A added class when in singlemode or something?
It's possible that I'm just overlooking it but I can't seem to find it.

@TRexStark
Copy link
Contributor Author

Hi @TRexStark

First of all the updates look great. But I noticed some small issues when using it as a single picker.

image

It still shows the sorting icon and it shows a empty square box when a video is picked

Could you have a look at that ?

Dave

I will look into that no worries.

Based on the feedback "dawoe#7 (comment)", the following updates have been made:

- Hide additional box container of the button when "Allow Multiple" is not toggled
- Hide the Sort Icon when "Allow Multiple" is not toggled

The items above will actually not exist (using ng-if instead of ng-hide) for single items
@TRexStark
Copy link
Contributor Author

Hi @TRexStark

First of all the updates look great. But I noticed some small issues when using it as a single picker.

image

It still shows the sorting icon and it shows a empty square box when a video is picked

Could you have a look at that ?

Dave

Hi @dawoe
That has been fixed.

Used ng-hide for the picker btn instead of ng-if as the button would disappear entirely when the item is removed
@dawoe dawoe merged commit bbf1587 into dawoe:develop Sep 26, 2020
@dawoe
Copy link
Owner

dawoe commented Sep 26, 2020

Hi @TRexStark

This looks great. I will merge this one and release a new version of the package

@dawoe dawoe mentioned this pull request Sep 26, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants