Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Embed edit button #15

Merged
merged 6 commits into from
Jan 22, 2021
Merged

Embed edit button #15

merged 6 commits into from
Jan 22, 2021

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jan 13, 2021

Added a basic edit button to fix issue #14
Furthermore some accessibility enhancements.

I haven't tested it yet inside Umbraco backoffice yet though.

@bjarnef bjarnef marked this pull request as ready for review January 13, 2021 16:48
@bjarnef
Copy link
Contributor Author

bjarnef commented Jan 13, 2021

@dawoe this should work now. I have tested this on a current project running on Umbraco v8.9.0
Not sure how this existing embed property here worked?
https://github.com/dawoe/OEmbed-Picker-Property-Editor/blob/develop/src/Dawoe.OEmbedPickerPropertyEditor.Web/App_Plugins/Dawoe.OEmbedPickerPropertyEditor/scripts/editor.controller.js#L14

It was previous called orignal, but was renamed to modify here and released in Umbraco v8.2:
umbraco/Umbraco-CMS@bf9eeb4#diff-73fe87536f61366d7ec14a0321f689597e2803eeb9a7586f7f049919e4f96e8d

@bjarnef
Copy link
Contributor Author

bjarnef commented Jan 20, 2021

Hi @dawoe

Did you had a chance to try this out? 😎

@dawoe dawoe merged commit 0a22536 into dawoe:develop Jan 22, 2021
@bjarnef bjarnef deleted the feature/embed-edit-button branch January 22, 2021 11:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjarnef @dawoe