Insert generates invalid SQL when multiple rows and values passed #26

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Open

balint-balku-scraperapi wants to merge 1 commit into db-migrate:master from balint-balku-scraperapi:patch-1

balint-balku-scraperapi commented Dec 30, 2020

insert generates invalid SQL statement when used to fill multiple columns:

db.insert('table',
  [ 'column1', 'column2' ],
  [ [ 'data11', 'data21' ], [ 'data12', 'data22' ] ]
);

delimiters are not added properly so in the final statement parts of the real data get sliced, ending up in statements like this:

INSERT INTO "table" ("column1","column2") VALUES ('data11''data21),('data12''data22);


          Insert generates invalid SQL when multiple rows and values passed

f1f5c89

Signed-off-by: Balint Balku <balint@scraperapi.com>

balint-balku-scraperapi force-pushed the patch-1 branch from f068849 to f1f5c89 Compare

December 31, 2020 00:01

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet