Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change kill signal from KILL to INT #3

Merged
merged 2 commits into from
Jun 6, 2012

Conversation

tombh
Copy link
Contributor

@tombh tombh commented Jun 6, 2012

This primarily addresses the change in kill signal (from KILL to INT) sent to Rack. It also has some new tests for runner#stop which required 1 or 2 other changes to runner.rb to accommodate those tests.

@dblock
Copy link
Owner

dblock commented Jun 6, 2012

Awesome, merging.

dblock added a commit that referenced this pull request Jun 6, 2012
Change kill signal from KILL to INT
@dblock dblock merged commit 3acfab9 into dblock:master Jun 6, 2012
@tombh
Copy link
Contributor Author

tombh commented Jun 6, 2012

Great :)

@dblock
Copy link
Owner

dblock commented Jun 6, 2012

Looks like build failed on RBX, checking it now.
http://travis-ci.org/#!/dblock/guard-rack/jobs/1546367
Speak up if you know a quick fix.

@tombh
Copy link
Contributor Author

tombh commented Jun 6, 2012

Yeah, saw that too. Looks like a dependency issue. Never used rbx,
must say my first though is just to remove it from .travis.yml

On 6 June 2012 13:25, Daniel Doubrovkine (dB.)
reply@reply.github.com
wrote:

Looks like build failed on RBX, checking it now.
http://travis-ci.org/#!/dblock/guard-rack/jobs/1546367
Speak up if you know a quick fix.


Reply to this email directly or view it on GitHub:
#3 (comment)

@dblock
Copy link
Owner

dblock commented Jun 6, 2012

Ok. I installed RBX head and it worked without any problems. I'll remove it for now and re-add whenever rubinius pulls it together :)

@tombh
Copy link
Contributor Author

tombh commented Jun 6, 2012

Fair enough :)

On 6 June 2012 14:57, Daniel Doubrovkine (dB.)
reply@reply.github.com
wrote:

Ok. I installed RBX head and it worked without any problems. I'll remove it for now and re-add whenever rubinius pulls it together :)


Reply to this email directly or view it on GitHub:
#3 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants