Add include_data_types flag to generate_source macro #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clrcrl or @matt-winkler, could you please take a look? |
|
Maybe, @dbeatty10 could take a look? |
dbeatty10
requested changes
Aug 29, 2022
There was a problem hiding this comment.
@GSokol makes sense for codegen to have an option to include the optional data_type metadata field -- thanks for opening!
I added some comments on some implementation details for the integration tests for you to explore. Could you take a look and see if any of them work?
Your current implementation is reasonable with a small footprint, and we can move forward with it if my suggested ideas all end up being dead-ends.
I've tried several approaches to generate the exact text, but it's not working. So returninig tests to dbt-labs@3a1267b state.
jeremyholtzman
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Add include_data_types flag to generate_source macro * Add test for include_data_types * Fix test_generate_source_all_args for Redshift * Fix test_generate_source_all_args for Snowflake * Fix int types test_generate_source_all_args for Snowflake * Fix test_generate_source_all_args for BigQuery * Fix typo * Fix typo * trying to avoid db-specific type defenitions * Dummy fix * Dummy fix * Dummy fix * Dummy fix * Revert to initial schema I've tried several approaches to generate the exact text, but it's not working. So returninig tests to 3a1267b state. * Example of generating data types for columns * Update changelog * Remove comment [skip ci] Co-authored-by: Doug Beatty <doug.beatty@dbtlabs.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
maindev/branchdev/branchDescription & motivation
Closes #75
Checklist