Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added comments to verbose regex in generate_model_import_ctes #93

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

graciegoheen
Copy link
Contributor

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is main
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Closes #91 - increases readability of generate_model_import_ctes.sql by using VERBOSE mode for regex and explanatory comments

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Copy link
Contributor

@b-per b-per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥐 Thanks so much for this Grace!
I really believe that it will make it much easier to leverage those regexes in other context!

@joellabes
Copy link
Contributor

Blessings upon you ❤️

leverage those regexes in other context

If this becomes necessary, please consider turning them into get_XXXX_regex() macros instead of copy-pasting them around.

@graciegoheen graciegoheen merged commit 9249b66 into main Dec 5, 2022
jeremyholtzman pushed a commit that referenced this pull request Apr 10, 2023
added comments to verbose regex in generate_model_import_ctes
@gwenwindflower gwenwindflower deleted the fix/use_verbose_regex branch February 28, 2024 23:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase readability of generate_model_import_ctes.sql by using VERBOSE mode for re
3 participants